Open
Conversation
Member
|
we have some conflicts with this PR. @DennisTemoye |
willypelz
reviewed
May 15, 2025
| "@nestjs/schematics": "^10.0.0", | ||
| "@nestjs/testing": "^11.0.15", | ||
|
|
||
|
|
willypelz
reviewed
May 15, 2025
Member
There was a problem hiding this comment.
There is no new change in package.json; There is no need to push your local installation changes. (package-lock.json)
Member
|
@DennisTemoye any update on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds unit tests for the UsersController in the User module. The tests cover various functionalities, including:
Profile Retrieval: Verifying the correct retrieval of the current user profile.
User Lookup: Testing user search by ID and email with proper handling of both successful and failed cases.
Password Change: Ensuring that the change password functionality is tested with valid inputs.
Lead Creation: Testing the creation of a temporary lead registration.
Account Deactivation and Reactivation: Ensuring proper handling of account deactivation and reactivation requests.
New User Registration: Verifying new user registration functionality, including error handling when a failure occurs.
Changes:
Created unit tests for the UsersController using Jest.
Mocked the UsersService methods to ensure isolated testing.
Implemented test cases for the following routes:
/myProfile
/findAll
/findOne/:id
/findByUsername
/changePassword
/createLead
/register
/newUserForm
/deactivateAccount
/requestReactivation
Testing:
All tests have passed successfully.
Mocked service methods to isolate the controller logic.